Fix cache delete bug master - #5698
Merged
Merged
Conversation
2 tasks
stnguyen90
approved these changes
Jul 20, 2023
eldadfux
reviewed
Jul 20, 2023
| ->setContext('bucket', $bucket) | ||
| ; | ||
|
|
||
| $deletes |
Member
There was a problem hiding this comment.
Didn't we have this to avoid a conflict when a file with a similar ID was recently deleted?
Contributor
There was a problem hiding this comment.
@eldadfux this event should already be triggered when the file is deleted, right?
stnguyen90
reviewed
Jul 20, 2023
stnguyen90
self-requested a review
July 20, 2023 20:10
stnguyen90
self-requested a review
July 20, 2023 20:12
stnguyen90
approved these changes
Jul 21, 2023
stnguyen90
left a comment
stnguyen90
left a comment
Contributor
There was a problem hiding this comment.
Approving this, but created #5861
This was referenced Jul 25, 2023
eldadfux
approved these changes
Aug 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix delete cache bug to master