feat: replace attributeId and indexId with key - #2505
Merged
TorstenDittmann merged 2 commits intoDec 17, 2021
Merged
TorstenDittmann merged 2 commits into
TorstenDittmann merged 2 commits into
Conversation
christyjacob4
approved these changes
Dec 16, 2021
Contributor
|
Looks Good 🚀 |
wess
approved these changes
Dec 16, 2021
TorstenDittmann
deleted the
feat-database-replace-attributeid-indexid
branch
December 17, 2021 10:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
attributeIdandindexIdwithkeyto avoid confusionWhy don't we replace it with
$id?We already use
$idinternally and concatenate the collection id and key. This is needed, since otherwise keys would need to be unique across collections.Test Plan
Have you read the Contributing Guidelines on issues?
✅