feat(database): add collection enable/disable - #2487
Merged
TorstenDittmann merged 6 commits intoDec 17, 2021
Merged
Conversation
TorstenDittmann
changed the title
kodumbeats
suggested changes
Dec 13, 2021
kodumbeats
left a comment
kodumbeats
left a comment
Contributor
There was a problem hiding this comment.
-
I had to go looking for
App::setResource('mode')to know what$modewas being injected to the route - can we add some comments? -
Do we care about adding this functionality to attributes/indexes routes?
…appwrite into feat-database-disable-collections
Contributor
Author
|
Contributor
|
is "mode" a bit to generic for the naming? |
Contributor
Author
Maybe 🤔 we can keep that in mind for the future. |
…appwrite into feat-database-disable-collections
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Test Plan
Related PRs and Issues
(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)
Have you read the Contributing Guidelines on issues?
(Write your answer here.)