Skip to content

Replaced $(...) instead of legacy backticked ... - #243

Merged
eldadfux merged 1 commit into
appwrite:masterfrom
dyyim741:fix-shellscript
Nov 2, 2019
Merged

eldadfux merged 1 commit into
appwrite:masterfrom
dyyim741:fix-shellscript

Conversation

@dyyim741

Copy link
Copy Markdown
Contributor

Backtick command substitution ... is legacy syntax with several
issues.

  1. It has a series of undefined behaviors related to quoting in POSIX.
  2. It imposes a custom escaping mode with surprising results.
  3. It's exceptionally hard to nest.

$(...) command substitution has none of these problems, and is therefore
strongly encouraged.

Backtick command substitution `...` is legacy syntax with several
issues.

1. It has a series of undefined behaviors related to quoting in POSIX.
2. It imposes a custom escaping mode with surprising results.
3. It's exceptionally hard to nest.

$(...) command substitution has none of these problems, and is therefore
strongly encouraged.
@eldadfux
eldadfux merged commit 5dda778 into appwrite:master Nov 2, 2019
@eldadfux

eldadfux commented Nov 2, 2019

Copy link
Copy Markdown
Member

THANK YOU! All changes merged 🥳


Please reach out to me on our Discord server if you would like me to send you some cool Appwrite stickers and magnets!

To say thank you, we have just invited you to join the Appwrite organization on GitHub. Accept the invite by visiting https://github.com/orgs/appwrite/invitation. By joining our team, you will officially be an Appwrite maintainer on GitHub.

You can change your membership visibility settings, so your new Appwrite team membership will show up on your personal GitHub profile.

ChiragAgg5k added a commit that referenced this pull request Sep 9, 2026
Bumps the requirement from ^0.10 to ^0.11 (installed 0.11.1). The 0.10.2..0.11.1
range is additive only — it adds the OAuth2 AuthorizationDetails reader and its
AuthorizationDetail enum (utopia-php/monorepo #242, #243); no existing class
changed — so nothing in server-ce needs updating. The lock change is limited to
utopia-php/auth.

Unblocks consumers that read a token's RFC 9396 authorization_details through the
new reader, in particular the Cloud OAuth2 access-token authorization path.
pull Bot pushed a commit to AmirulAndalib/appwrite that referenced this pull request Sep 26, 2026
…n-details-list-shape

fix(auth): reject non-list authorization_details shapes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants