Skip to content

Remove executable bit from non-executable files - #242

Merged
eldadfux merged 1 commit into
appwrite:masterfrom
friederbluemle:update-project
Nov 1, 2019
Merged

eldadfux merged 1 commit into
appwrite:masterfrom
friederbluemle:update-project

Conversation

@friederbluemle

Copy link
Copy Markdown
Contributor

A bunch of non-executable files in the repo erroneously had the executable bit set. This fixes is by changing the file mode from 755 to 644.

@MoshiBin MoshiBin left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@friederbluemle

Copy link
Copy Markdown
Contributor Author

Rebased onto latest default branch.

@eldadfux

eldadfux commented Nov 1, 2019

Copy link
Copy Markdown
Member

Hey @friederbluemle, can you please explain the change in the image files? How can I validate other and future files we might add to the project?

@friederbluemle

Copy link
Copy Markdown
Contributor Author

Hi @eldadfux - I'm not sure what caused the image files to have the executable bit set, but one possibility is an extracted .zip archive file on macOS. There seems to be a bug with the default extracting tool on macOS that sets +x on all files.

I am not aware of an "easy" way to validate, except to check the correct file permissions for each newly added file to the repo (the executable bit should only be set for executable shell scripts). Unfortunately it seems the GitHub UI only displays file permissions after the file has been added to the repo:

image

@eldadfux
eldadfux merged commit b172e39 into appwrite:master Nov 1, 2019
@eldadfux

eldadfux commented Nov 1, 2019

Copy link
Copy Markdown
Member

Thank you for the info and for improving Appwrite @friederbluemle!

I don't remember if you already signed up to get some Hacktoberfest swags, but if not, please contact me on Discord!

And we will be thrilled if you will join us on our Discord server, you'll be a great addition to our community!

@friederbluemle
friederbluemle deleted the update-project branch November 1, 2019 21:20
ChiragAgg5k added a commit that referenced this pull request Sep 9, 2026
Bumps the requirement from ^0.10 to ^0.11 (installed 0.11.1). The 0.10.2..0.11.1
range is additive only — it adds the OAuth2 AuthorizationDetails reader and its
AuthorizationDetail enum (utopia-php/monorepo #242, #243); no existing class
changed — so nothing in server-ce needs updating. The lock change is limited to
utopia-php/auth.

Unblocks consumers that read a token's RFC 9396 authorization_details through the
new reader, in particular the Cloud OAuth2 access-token authorization path.
pull Bot pushed a commit to AmirulAndalib/appwrite that referenced this pull request Sep 26, 2026
…on-details

feat(auth): add AuthorizationDetails reader for RFC 9396 grants
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants