Skip to content

feat(refactor-db): prep the API for UI work - #1654

Merged
TorstenDittmann merged 82 commits into
feat-database-indexingfrom
feat-db-refactor-ui-fixes
Nov 24, 2021
Merged

feat(refactor-db): prep the API for UI work#1654
TorstenDittmann merged 82 commits into
feat-database-indexingfrom
feat-db-refactor-ui-fixes

Conversation

@kodumbeats

@kodumbeats kodumbeats commented Sep 24, 2021 •
edited by TorstenDittmann
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

This PR brings together most of the API work left to be merged so we can complete the outstanding UI tasks.

Test Plan

Current test suite.

Todo

  • UI - Support all attribute types and icons (int, float, boolean, ip, email)
  • UI - Add attributes limit
  • UI - Add indexes limit
  • UI - Add attribute min, max and default
  • UI - Default values in the UI should obey attribute format rules
  • UI - Disable new document when no attributes
  • UI - Document
    • Array support
    • Required support
    • Min / Max support
  • UI - Unique index check
  • UI - Getting error when trying duplicated unique key:
Message: Lock wait

Related PRs and Issues

#1281

Have you read the Contributing Guidelines on issues?

Yes

@kodumbeats
kodumbeats marked this pull request as draft September 24, 2021 02:47
@Meldiron

Meldiron commented Sep 24, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • [API!] Float vs integer needs to be fixed ni both FloatValidator and on database level
  • [API!] "Failed" attributes cannot be deleted
  • [UI!] ID in documents list will disappear if the first attribute has status failed
  • [API!] String, required... Let's me save without data
  • [UI!] If you create a document with an array attribute, save it, then try to edit it, you will end up with only one item holding json array
  • [UI!+API?]Missing "usage" section
  • [NONE] Hacktoberfest issues are cancelled, no time to prepare alpha
  • [UI!] Texts are missing for collection/document level permission
  • [UI!+API?] What if we have array=true? Do we disable default? Do we support it?
  • [UI!+API!] It lets me create index for column that failed (it fails too)

@kodumbeats kodumbeats mentioned this pull request Oct 13, 2021
Merged
@TorstenDittmann
fix(database): documents audit logs
a7d550b
@TorstenDittmann
Merge branch 'feat-database-indexing' of https://github.com/appwrite/…
b99ea3a 
…appwrite into pr/2212
@TorstenDittmann
active travis
5a3c083
@TorstenDittmann
disable travis
4d890c5
@TorstenDittmann
Merge pull request #2212 from kodumbeats/feat-db-refactor-ui-fixes
6f881e8 
feat(db-refactor): merge feat-database-indexing changes
@TorstenDittmann
fix merge leftovers
5f7ff19
@TorstenDittmann
Merge branch 'feat-db-refactor-ui-fixes' of https://github.com/appwri…
6352c89 
…te/appwrite into feat-db-refactor-ui-fixes
@TorstenDittmann
Merge branch 'feat-database-indexing' of https://github.com/appwrite/…
1500ffe 
…appwrite into feat-db-refactor-ui-fixes
@TorstenDittmann
re-build js & css after merge
a7a15d5
@TorstenDittmann
fix(ui): usage for collections
ae05fa1
@TorstenDittmann
fix(ui): total users
839284a
@TorstenDittmann
fix all usage ui
7224520
@TorstenDittmann
Merge branch 'feat-database-indexing' of https://github.com/appwrite/…
df13983 
…appwrite into feat-db-refactor-ui-fixes
@TorstenDittmann
remove data-debug
886e19b
@TorstenDittmann
fix(ui): disabled default value when required or array
adf5c1b
@TorstenDittmann

TorstenDittmann commented Oct 27, 2021

Copy link
Copy Markdown
Contributor

Fixed:

  • Usage sections
  • Disable default if required or array

@TorstenDittmann
TorstenDittmann marked this pull request as ready for review November 8, 2021 13:30
@TorstenDittmann
fix(ui): multiple arrays on document
1c96af3
@TorstenDittmann
fix(ui): single array property
b038837
@TorstenDittmann
fix(ui): cleanup comments and whitespace
dfcf2bd
@TorstenDittmann
Merge branch 'feat-database-logs-pagination' of https://github.com/ap…
47b6fe5 
…pwrite/appwrite into feat-db-refactor-ui-fixes
@TorstenDittmann
fix(ui): logs pagination
f2eb6ae
@TorstenDittmann
Merge branch 'feat-database-indexing' of https://github.com/appwrite/…
0fc1812 
…appwrite into feat-db-refactor-ui-fixes
@TorstenDittmann
fix charts hover
60c6f85
@TorstenDittmann
fix(ui): adapt usage legends
7d0eae7
@TorstenDittmann
feat(ui): add users usage
db478c1
@TorstenDittmann
fix(ui): collection permission binding
f9ebeac
@TorstenDittmann
fix(ui): multiple issues in db
3a8eb40
@TorstenDittmann
fix(ui): error messages from exception
f68ab29
@TorstenDittmann
fix(ui): add enum attribute
7904d79
@TorstenDittmann
fix(forms): don't include disabled form elements
c549e75
@TorstenDittmann
feat(ui): introduce alpine.js
ab70276
@TorstenDittmann
feat(js): update gulpfile
8d3a502
@TorstenDittmann
fix(ui): input validation for ids
7be4211
@TorstenDittmann
refactor(ui): list documents
7c8135b
@TorstenDittmann
update specs
b19217c
@TorstenDittmann
fix(ui): forms and database list
9e8cb3a
@TorstenDittmann
Merge branch 'feat-database-indexing' of https://github.com/appwrite/…
db0a75a 
…appwrite into feat-db-refactor-ui-fixes
@TorstenDittmann
Merge branch 'feat-database-indexing' of https://github.com/appwrite/…
0a38f07 
…appwrite into feat-db-refactor-ui-fixes
@TorstenDittmann
fix(tests): realtime tests
fba2529
@TorstenDittmann
fix(ui): input id validation pattern
fe2b598
@TorstenDittmann
TorstenDittmann merged commit 28e3450 into feat-database-indexing Nov 24, 2021
@TorstenDittmann
TorstenDittmann deleted the feat-db-refactor-ui-fixes branch November 24, 2021 17:31
@j9367 j9367 mentioned this pull request Sep 13, 2022
Closed
2 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

See More

Successfully merging this pull request may close these issues.

4 participants

@kodumbeats @Meldiron @TorstenDittmann @eldadfux