Skip to content

Feat sync session collection - #1400

Merged
eldadfux merged 13 commits into
feat-db-refactor-routesfrom
feat-sync-session-collection
Jul 19, 2021
Merged

eldadfux merged 13 commits into
feat-db-refactor-routesfrom
feat-sync-session-collection

Conversation

@eldadfux

@eldadfux eldadfux commented Jul 16, 2021 •

Copy link
Copy Markdown
Member

What does this PR do?

  • Adds a dedicated collection for storing use sessions.
  • Fix a bug where we injected consoleDB instead of the new db instance
  • Removed some old TODO comments
  • Added trace log to the HTML error template on dev mode for easy debugging
  • Fixed OAuth and Anonymous tests - @TorstenDittmann please verify

Test Plan

Fixed some e2e tests

Related PRs and Issues

#1281

Have you read the Contributing Guidelines on issues?

Yes

@eldadfux
eldadfux requested review from TorstenDittmann and kodumbeats and removed request for TorstenDittmann July 18, 2021 08:06
Comment thread app/config/collections2.php Outdated
Comment thread app/config/collections2.php Outdated
Comment thread app/controllers/api/account.php

@kodumbeats kodumbeats left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

@eldadfux
eldadfux merged commit 3b32c08 into feat-db-refactor-routes Jul 19, 2021
@eldadfux
eldadfux deleted the feat-sync-session-collection branch July 29, 2021 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants