Skip to content

[Bug] Enable Bitcode by Default for GameKit#3

Closed
justadaniel wants to merge 1 commit into
apple:mainfrom
justadaniel:main
Closed

[Bug] Enable Bitcode by Default for GameKit#3
justadaniel wants to merge 1 commit into
apple:mainfrom
justadaniel:main

Conversation

@justadaniel
Copy link
Copy Markdown

Changing Bitcode to YES by Default will bundle the GameKit into UnityFramework preventing build errors in Xcode. This provides a more seamless experience for game developers who just want it bundled. Before hand, the only bundled framework would be for macOS.

Example Build Errors with ENABLE_BITCODE = NO
Screen Shot 2022-07-13 at 4 16 11 PM

Changing Bitcode to YES by Default will bundle the GameKit into UnityFramework preventing build errors in Xcode
@jared-marsau
Copy link
Copy Markdown
Collaborator

To align with the upcoming deprecation of bitcode, this change will not be taken.

For more information, please see: https://developer.apple.com/documentation/Xcode-Release-Notes/xcode-14-release-notes

Changes summarized here:

Starting with Xcode 14, bitcode is no longer required for watchOS and tvOS applications, and the App Store no longer accepts bitcode submissions from Xcode 14.

@justadaniel
Copy link
Copy Markdown
Author

Is there a fix for the error above without using bitcode? It doesn't seem to export the .framework plugin for most of these unity plugins.

@DaniBarca
Copy link
Copy Markdown
Contributor

DaniBarca commented Jul 14, 2022

We have the same issue and actually abandoned the plugin because of this. My team is waiting for some update.

@jared-marsau
Copy link
Copy Markdown
Collaborator

@justadaniel I am not able to reproduce your issue. Please share with me your system config including:

  • Host Mac hardware model
  • Version of macOS on host system
  • Target device hardware model
  • Target device OS version
  • Xcode version
  • Unity version

@justadaniel
Copy link
Copy Markdown
Author

justadaniel commented Jul 14, 2022

I am not able to reproduce your issue. Please share with me your system config including:

Host Mac
Mac Mini (M1, 2020)

Version of macOS on Host System
macOS 12.4

Target Device Hardware Model

  • iPhone XR
  • iPad Pro 11" (M1)

Target Device OS Version

  • iOS 16.0b3
  • iPadOS 16.0b3

Xcode Version
14.0 Beta 3

Unity Version

  • Game built with 2021.3.4f1 LTS
  • Plugin source built with 2020.3.33f1

@jared-marsau
Copy link
Copy Markdown
Collaborator

Thank you. I will investigate.

@DaniBarca
Copy link
Copy Markdown
Contributor

DaniBarca commented Oct 31, 2022

Hello. Is there any update on this issue? We can't get rid of these errors.

jared-marsau added a commit that referenced this pull request Nov 29, 2023
Introduces availability checks to Apple.Core. This comes in two parts: Availability attributes and runtime Availability checks. Attributes are used to decorate C# API calls with availability information including the specific versions of each OS that an API was introduced, deprecated, renamed, or obsoleted. Availability checks allow users to wrap blocks of code which call API that may only be available in certain runtimes. By wrapping these code blocks, users can prevent the wrapped code from being called on unsupported OS versions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants