Skip to content

Fix: use values instead of itervalues and extract parser from class b…#4

Merged
pablodiazgutierrez merged 1 commit into
masterfrom
fix/itervalues
Dec 9, 2020
Merged

Fix: use values instead of itervalues and extract parser from class b…#4
pablodiazgutierrez merged 1 commit into
masterfrom
fix/itervalues

Conversation

@Navega

@Navega Navega commented Dec 9, 2020

Copy link
Copy Markdown

…ecause "self" isn't used for it.

@Navega Navega requested review from ihaveajob and kharenzze December 9, 2020 23:47
@pablodiazgutierrez pablodiazgutierrez merged commit bc94dac into master Dec 9, 2020

@kharenzze kharenzze left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@kharenzze kharenzze left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kharenzze

Copy link
Copy Markdown
Contributor

I cannot find the 'approve' button. Maybe because it's already merged

@pablodiazgutierrez

pablodiazgutierrez commented Dec 10, 2020 via email

Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants