Repository navigation
fix(core): stop polling timers on restart and disconnect - #363
Merged
bennypowers merged 1 commit intoOct 29, 2026
Conversation
🦋 Changeset detectedLatest commit: c35a903 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
👷 Deploy request for apollo-elements pending review.Visit the deploys page to approve it
|
bennypowers
approved these changes
Oct 29, 2026
Member
|
Thanks for the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
startPolling()is called again, whenstopPolling()is called, and when the host disconnects.Related to the historical disconnect-polling report in #192. That report's reproduction used the
pollIntervaloption; this change covers the separate manualstartPolling()interval, which survives host disconnection after the controller cleanup refactor.Validation
npm exec -- tsc --noEmit --pretty false -p packages/core/tsconfig.json— passed.apollo-query-controller.ts:389.Failed to resolve module specifier "\ttestschema.ts"), so that browser test did not execute. No full-suite or CI result is claimed.