Skip to content

[SCB-2333] HttpServerOptions.maxFormAttributeSize can be configurable#2579

Merged
liubao68 merged 2 commits into
apache:1.3.xfrom
david6969xin:Branch_SCB2333
Sep 16, 2021
Merged

[SCB-2333] HttpServerOptions.maxFormAttributeSize can be configurable#2579
liubao68 merged 2 commits into
apache:1.3.xfrom
david6969xin:Branch_SCB2333

Conversation

@david6969xin

@david6969xin david6969xin commented Sep 16, 2021

Copy link
Copy Markdown
Contributor

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install -Pit to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter

codecov-commenter commented Sep 16, 2021

Copy link
Copy Markdown

Codecov Report

Merging #2579 (dfcf692) into 1.3.x (edf1d99) will increase coverage by 0.03%.
The diff coverage is 89.04%.

Impacted file tree graph

@@             Coverage Diff              @@
##              1.3.x    #2579      +/-   ##
============================================
+ Coverage     82.96%   82.99%   +0.03%     
- Complexity      740      746       +6     
============================================
  Files          1230     1232       +2     
  Lines         32943    33015      +72     
  Branches       2990     2990              
============================================
+ Hits          27332    27402      +70     
- Misses         4429     4433       +4     
+ Partials       1182     1180       -2
Impacted Files Coverage Δ
...che/servicecomb/demo/jaxrs/server/FormRequest.java 0.00% <0.00%> (ø)
...rvicecomb/demo/jaxrs/client/FormRequestClient.java 76.00% <76.00%> (ø)
...che/servicecomb/demo/jaxrs/client/JaxrsClient.java 90.71% <100.00%> (+0.03%) ⬆️
...ecomb/transport/rest/vertx/RestServerVerticle.java 74.63% <100.00%> (+2.19%) ⬆️
...vicecomb/transport/rest/vertx/TransportConfig.java 97.77% <100.00%> (+1.28%) ⬆️
...in/java/org/apache/servicecomb/core/SCBEngine.java 81.57% <0.00%> (-1.58%) ⬇️
.../org/apache/servicecomb/provider/pojo/Invoker.java 94.36% <0.00%> (-1.41%) ⬇️
...egistry/client/http/ServiceRegistryClientImpl.java 62.27% <0.00%> (+0.39%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edf1d99...dfcf692. Read the comment docs.

@liubao68 liubao68 merged commit c2655de into apache:1.3.x Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liubao68 liubao68 liubao68 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@david6969xin @codecov-commenter @liubao68