Repository navigation
Added the AsciiDoc version of 'Install Guide' documentation - #39
Merged
Merged
Conversation
added 6 commits
September 17, 2019 18:58
mraible
added a commit
that referenced
this pull request
Nov 19, 2026
Quotes in text are encoded again as " and ', so a sanitized title or tagline is still safe when a theme puts it inside an attribute value. Attribute values are left as jsoup writes them, and sanitizing twice gives the same result. User, bookmark and bookmark folder setters now use a plain-text variant that leaves an ampersand in the text as an ampersand and doesn't read it as the start of an entity, so an e-mail address, OpenID URL or name with an & is stored as typed. Tags are still stripped and quotes still encoded for these fields. RSS entry and comment titles are plain text, so the feed macros now decode the entities in the entry title before XML-escaping it. A title with an & or a quote no longer shows up as & or " in feed readers. The allow-list keeps area, map and param again, along with rel and target on links, usemap on images, value and type on list items, and scope and nowrap on table cells. An area's href is still dropped. Styles are checked one declaration at a time. A declaration is dropped if it has expression(, eval( or javascript( in any case, a url() that isn't http or https, image-set(), a behavior or -moz-binding property, a backslash or a comment. The other declarations are kept, so scroll-behavior and http(s) background images work again. Width and height must be ASCII digits with no surrounding spaces, and the long-input test uses assertTimeoutPreemptively with a 30 second bound.
mraible
added a commit
that referenced
this pull request
Nov 20, 2026
Neither trust setting stores an ampersand encoded: trusted admins' names are stored as typed, and the sanitizer used for untrusted admins only encodes angle brackets and quotes. UserWrapper now decodes just <, >, " and ', and only when weblogAdminsUntrusted is true, before escaping, so a name typed as "Tom & Jerry" displays as typed in both modes. Media file authors in the feeds go through UserWrapper too, with a new $utils.wrapUser(), instead of decoding the stored name.
mraible
added a commit
that referenced
this pull request
Nov 20, 2026
The wrapper decodes the ' the sanitizer stores and escapeHtml4 leaves an apostrophe as it is, so a name reached templates with a raw apostrophe. A custom theme that printed a name inside a single-quoted attribute got markup it didn't expect. The wrapper now encodes apostrophes as ', as the stored value had them.
mraible
added a commit
that referenced
this pull request
Nov 20, 2026
…nges A name keeps the encoding it was saved with, but the wrapper decoded the sanitizer's entities only while weblogAdminsUntrusted was true. After an operator turned the setting off, a name such as O'Brien saved earlier showed as O'Brien on pages and in feeds. The wrapper now decodes those few entities whatever the setting is, as it decoded every entity before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.