Repository navigation
Conversation
Accounts created before users.passwords.externalAuthValue changed still have the old marker stored, encoded or not, and the encoder only recognized the current marker and the default, so the old marker matched at login. The new users.passwords.externalAuthValue.previous setting lists earlier markers, which are refused at login and can't be chosen as passwords, the same as the current one. Empty entries are ignored so an empty password never counts as a marker.
This was referenced Nov 20, 2026
…rker BCrypt gives some passwords other than a marker the same hash as the marker, so an exact comparison with the marker isn't enough to keep it from matching. After the delegate matches, the encoder now also checks whether the current, default or a previous marker matches the stored value, and refuses the password if one does. The marker list is read once per check.
An account whose real password equals the current, default or a previous marker can't log in, and until now the log didn't say why. The encoder now logs an info line for that refusal, without the password, so an administrator can tell it from a wrong password and set a new one.
The list is comma-separated, so a marker that contains a comma can't be listed there. roller.properties now says so, along with listing earlier values in the same restart that changes the setting and the accounts that need an administrator to set a new password. Roller also logs a warning at startup when the configured marker contains a comma.
…coder ExternalLoginMarkerPasswordTest now checks that registration, the profile page and user administration refuse a marker listed in users.passwords.externalAuthValue.previous, and its tearDown restores the configuration in a finally block. The provider tests for previous markers also check the encoder directly, and the list test covers spaces around an entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A follow-up to #304, from Dave's review of its 6.1.x twin #306.
When an admin changes
users.passwords.externalAuthValue, accounts created earlier still store the old marker, encoded or not, and Roller only recognized the current marker and the default<externalAuth>.users.passwords.externalAuthValue.previoussetting takes a comma-separated list of earlier markers. They're refused at login and can't be chosen as passwords, the same as the current one. Empty entries are ignored, so an empty password field never counts as a marker.ExternalLoginPlaceholderTest covers an earlier marker stored encoded and unencoded, empty and spaced entries in the list, and a password that BCrypt treats as equal to the current, default or a previous marker. ExternalLoginMarkerPasswordTest checks that registration, the profile page and user administration refuse a previous marker. #306 has the same change for 6.1.x.