Skip to content

Keep the PostgreSQL 18 data directory out of the Docker build context - #363

Merged
mraible merged 1 commit into
masterfrom
dockerignore-postgresql-18-data
Nov 20, 2026
Merged

mraible merged 1 commit into
masterfrom
dockerignore-postgresql-18-data

Conversation

@mraible

@mraible mraible commented Nov 19, 2026

Copy link
Copy Markdown
Contributor

A follow-up to #351, which moved the compose stack's database to docker/postgresql-18-data.

.gitignore listed the new directory but .dockerignore didn't, so it became part of the build context for the Roller image:

  • On Linux the directory belongs to the container's postgres user, so the next docker compose up --build fails with a permission error while reading the context.
  • Elsewhere the whole database is sent to the Docker daemon on every build.

The compose comment about migrating old data now says to run the old image on the old directory and pg_dump from that, since the old container is gone once the stack is recreated.

Not run: I didn't build the image; the change is one ignore line and a comment.

The compose stack now stores its database in docker/postgresql-18-data, which .gitignore listed but .dockerignore didn't, so the directory became part of the build context for the Roller image. On Linux that fails the next build with a permission error, and elsewhere it sends the whole database to the Docker daemon. The compose comment about migrating old data now says to run the old image on the old directory, since the old container is gone once the stack is recreated.
@mraible mraible added the 7.0.0 label Nov 19, 2026

@snoopdave snoopdave left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review of c9ec79ca9: Adds the PostgreSQL 18 data directory to .dockerignore and corrects the migration note in docker-compose.yml. Matches the layout #351 introduced.

No new issues found.

@mraible
mraible merged commit 3530606 into master Nov 20, 2026
9 checks passed
@mraible
mraible deleted the dockerignore-postgresql-18-data branch November 20, 2026 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants