Repository navigation
Conversation
jQuery 4.1.0 and 3.8.0, released on 2026-11-17, fix a ReDoS in selector identifier matching, where a long chain of escapes followed by an invalid character could hang the page. The admin UI moves from the jQuery 4.0.0 webjar to 4.1.0. The Gaurav theme's bundled jquery.js moves from 3.7.1 to 3.8.0, the unmodified jquery.min.js from the npm package (integrity checked), so the theme's Bootstrap 3 plugins keep the 3.x API. LICENSE, the binary LICENSE and CHANGES name the new versions.
Bootstrap 3's JavaScript refuses to run with jQuery 4, and the theme used it only for the navbar's collapse button and Categories dropdown. A small script, js/navbar.js, now toggles the same Bootstrap 3 CSS classes (in and open) and aria-expanded, closes the dropdown on an outside click or Escape, and needs no library. jquery.js and bootstrap.js are removed from the theme, its theme.xml and the LICENSE files, so the admin UI's jQuery 4.1.0 is the only jQuery left in Roller. The theme keeps Bootstrap 3.4.1's CSS, so it looks the same. Weblogs that customized the theme keep their own copies of the old files.
snoopdave
reviewed
Nov 20, 2026
snoopdave
left a comment
Contributor
There was a problem hiding this comment.
Review of 102fd74cd: The dependency update and Gaurav asset references are consistent. Two behavior gaps remain: keyboard navigation in the replacement dropdown and a mobile search change present in #350 but absent here. This was a read-only review; no build was run.
The Gaurav theme's Categories dropdown again handles the keys Bootstrap 3's dropdown did: Arrow Up/Down on the toggle opens the menu and then moves between its links, and Escape closes it and returns focus to the toggle instead of leaving it on a hidden link. The new-user journey UI test previews the new weblog in the Gaurav theme and drives the menu from the keyboard. The mobile search form's empty-search check called jQuery Mobile's popup API, but no weblog page loads jQuery, so the check threw and the empty search was submitted. As on 6.1.x, it now opens the alert by setting the URL fragment, which the Basic Mobile theme's :target rule displays. BasicMobileThemeRenderingTest renders the real macro and checks it.
Opening the Gaurav theme's Categories menu with a click now focuses its toggle, as Bootstrap 3 did, so Arrow Up/Down work afterwards in browsers that don't focus a clicked link, such as Safari. Space on the toggle opens the menu again. The script also handles a few more cases the way Bootstrap did: the navbar's collapse button closes an open dropdown, arrow keys and Space typed in a form field inside a dropdown are left to the field, and a collapse button with an empty or unusable data-target does nothing instead of throwing. Click and keyboard handling now find the dropdown the same way. The new-user journey UI test checks Space and a click followed by Arrow Down.
A customized mobile template that still loads jQuery Mobile showed nothing on an empty search, because the check no longer called its popup. The check uses the popup again when jQuery Mobile is on the page, and the theme's :target alert otherwise. The :target alert now replaces the URL fragment instead of adding history entries, so Back doesn't open it again. It focuses the alert's OK link, and OK hides the alert and returns focus to the search field, as jQuery Mobile's popup did. BasicMobileThemeRenderingTest uses the standard ASF license header and also checks that the Basic Mobile stylesheet has the :target rule that shows the alert.
A weblog on the shared Gaurav theme whose own templates load the theme's js/jquery.js or js/bootstrap.js gets errors for those files after upgrading, so the entry moves from Build and packaging to the behaviour changes and says so.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jQuery 4.1.0 and 3.8.0 came out on 2026-11-17 with a fix for slow selector matching: a long chain of escapes followed by an invalid character could hang the page.
js/navbar.js, now toggles the same Bootstrap 3 CSS classes andaria-expanded, and keeps the dropdown behaviour Bootstrap had: a click or Space opens it and focuses the toggle, Arrow Up/Down open it and move between its links, Escape closes it and returns focus to the toggle, and an outside click or the collapse button closes it. Keys typed in a form field are left alone. The theme keeps Bootstrap 3.4.1's CSS, so it looks the same.:targetrule without adding history entries, focuses its OK link, and returns focus to the search field on OK. A customized template that still loads jQuery Mobile keeps using its popup.js/jquery.jsorjs/bootstrap.jsnow gets errors for those files. Weblogs that customized the theme keep their own copies of the old files.BasicMobileThemeRenderingTestrenders the real search macro and checks the theme's:targetrule. The new-user journey UI test previews the new weblog in the Gaurav theme and drives the Categories menu from the keyboard and after a click. I also checked the menu and the Basic Mobile alert in Chromium and WebKit.The 6.1.x changes are in #349 and #350.