Skip to content

Ignore commented-out filter mappings in FilterOrderTest - #344

Merged
mraible merged 1 commit into
roller-6.1.xfrom
filter-order-test-skips-comments-6.1.x
Nov 18, 2026
Merged

mraible merged 1 commit into
roller-6.1.xfrom
filter-order-test-skips-comments-6.1.x

Conversation

@mraible

@mraible mraible commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

Follows up #307 from review.

FilterOrderTest read filter mappings straight from web.xml, so a commented-out mapping would have counted. It now strips XML comments first.

Tests: a new FilterOrderTest case checks that a commented-out mapping is ignored.

The test read filter mappings straight from web.xml, so a commented-out mapping would have counted. It now strips XML comments first, and a new test checks that a commented-out mapping is ignored.
@mraible
mraible requested a review from snoopdave November 18, 2026 04:16

@snoopdave snoopdave left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mraible
mraible merged commit 3841596 into roller-6.1.x Nov 18, 2026
7 checks passed
@mraible
mraible deleted the filter-order-test-skips-comments-6.1.x branch November 18, 2026 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants