Skip to content

Remove the overlay mode flag and the external media include page - #342

Merged
mraible merged 1 commit into
masterfrom
remove-unused-media-overlay-code
Nov 20, 2026
Merged

mraible merged 1 commit into
masterfrom
remove-unused-media-overlay-code

Conversation

@mraible

@mraible mraible commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

Follows up #309 from review.

With the overlay mediaFileAdd action gone, nothing reads overlayMode: MediaFileImageChooser was given it but never used it, and MediaFileAdd only runs outside the overlay. The flag is removed from MediaFileBase and MediaFileAdd.

The mediaFileAddExternalInclude action, its tile and MediaFileAddExternalInclude.jsp aren't linked from any page either, so they're removed too.

MediaFileBase.java had mixed CRLF and LF line endings and now has LF only, so its diff is larger than the change; with whitespace ignored, it's ten removed lines.

Tests: StrutsParameterAnnotationTest no longer lists the removed JSP as an exception.

With the overlay mediaFileAdd action gone, nothing reads overlayMode: MediaFileImageChooser was given it but never used it, and MediaFileAdd only runs outside the overlay. The mediaFileAddExternalInclude action, its tile and its JSP aren't linked from any page either, so they go too.
@mraible
mraible requested a review from snoopdave November 18, 2026 04:16

@snoopdave snoopdave left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review of 41b48d86d: Removes the unused overlayMode flag and the unlinked external media include action, tile and JSP. With whitespace ignored the change is small, and nothing in app/src or the UI tests still refers to the removed names.

No new issues found.

@mraible
mraible merged commit cf67ddb into master Nov 20, 2026
9 checks passed
@mraible
mraible deleted the remove-unused-media-overlay-code branch November 20, 2026 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants