Repository navigation
Remove the overlay mode flag and the external media include page - #342
Merged
Merged
Conversation
With the overlay mediaFileAdd action gone, nothing reads overlayMode: MediaFileImageChooser was given it but never used it, and MediaFileAdd only runs outside the overlay. The mediaFileAddExternalInclude action, its tile and its JSP aren't linked from any page either, so they go too.
snoopdave
reviewed
Nov 20, 2026
snoopdave
left a comment
Contributor
There was a problem hiding this comment.
Review of 41b48d86d: Removes the unused overlayMode flag and the unlinked external media include action, tile and JSP. With whitespace ignored the change is small, and nothing in app/src or the UI tests still refers to the removed names.
No new issues found.
snoopdave
approved these changes
Nov 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows up #309 from review.
With the overlay
mediaFileAddaction gone, nothing readsoverlayMode:MediaFileImageChooserwas given it but never used it, andMediaFileAddonly runs outside the overlay. The flag is removed fromMediaFileBaseandMediaFileAdd.The
mediaFileAddExternalIncludeaction, its tile andMediaFileAddExternalInclude.jsparen't linked from any page either, so they're removed too.MediaFileBase.javahad mixed CRLF and LF line endings and now has LF only, so its diff is larger than the change; with whitespace ignored, it's ten removed lines.Tests:
StrutsParameterAnnotationTestno longer lists the removed JSP as an exception.