Repository navigation
Don't start a session for Roller UI stylesheets, scripts and images - #332
Merged
Merged
Conversation
LoadSaltFilter started a session and put a form salt in the cache for every request under /roller-ui, including the static files in /roller-ui/styles, /roller-ui/scripts and /roller-ui/images. It now passes those straight through.
snoopdave
reviewed
Nov 18, 2026
| public class LoadSaltFilter implements Filter { | ||
|
|
||
| /** Roller UI static files, which never hold a form. */ | ||
| static final String[] STATIC_PATHS = {"/roller-ui/styles/", "/roller-ui/scripts/", "/roller-ui/images/"}; |
Contributor
There was a problem hiding this comment.
Important: /roller-ui/theme/ also contains static CSS and images. The frontpage CSS requests images from that directory, and those requests still reach getSession(true) through the /roller-ui/* mapping. Add /roller-ui/theme/ to STATIC_PATHS and cover it in the no-session test.
Contributor
Author
There was a problem hiding this comment.
Added /roller-ui/theme/ to STATIC_PATHS, and the no-session test now requests /roller-ui/theme/tan/menutab-sel.gif and expects four chained requests. The test fails without the change.
Requests under /roller-ui/theme/, such as the front-page tab images, no longer create a session, and the no-session test covers that directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 6.1.x version of #310. 6.1.x's LoadSaltFilter has no rendering-path skip, so only the static-file skip is added, for
/roller-ui/styles,/roller-ui/scripts,/roller-ui/imagesand/roller-ui/theme.LoadSaltFilterTest: staticFilesGetNoSessionAndNoSalt, which covers all four directories, fails without the change. mvn test passes, and the Selenium integration tests pass.
CHANGES entries for the 6.1.8 fixes will come in one PR.