Repository navigation
Serve a media file only at its own weblog's address - #329
Merged
Merged
Conversation
MediaResourceServlet now answers 404 unless the requested media file belongs to the weblog named in the address.
snoopdave
reviewed
Nov 18, 2026
snoopdave
left a comment
Contributor
There was a problem hiding this comment.
Review of befa5e24a: The ownership check runs before conditional responses and file delivery. The new test would fail without the fix. Compared with #308, the fix and tests match; the servlet imports reflect the branches’ javax/jakarta split.
No issues found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 6.1.x version of #308. The main code applied as is.
MediaResourceServletTest: the other-weblog case fails without the change. mvn test passes (535 run, 1 skipped).
CHANGES entries for the 6.1.8 fixes will come in one PR.