Skip to content

Serve a media file only at its own weblog's address - #329

Merged
mraible merged 1 commit into
roller-6.1.xfrom
media-file-own-weblog-6.1.x
Nov 18, 2026
Merged

mraible merged 1 commit into
roller-6.1.xfrom
media-file-own-weblog-6.1.x

Conversation

@mraible

@mraible mraible commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

The 6.1.x version of #308. The main code applied as is.

MediaResourceServletTest: the other-weblog case fails without the change. mvn test passes (535 run, 1 skipped).

CHANGES entries for the 6.1.8 fixes will come in one PR.

MediaResourceServlet now answers 404 unless the requested media file belongs to the weblog named in the address.

@snoopdave snoopdave left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review of befa5e24a: The ownership check runs before conditional responses and file delivery. The new test would fail without the fix. Compared with #308, the fix and tests match; the servlet imports reflect the branches’ javax/jakarta split.

No issues found.

@mraible
mraible requested a review from snoopdave November 18, 2026 03:21

@snoopdave snoopdave left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@mraible
mraible merged commit 8e71ad2 into roller-6.1.x Nov 18, 2026
7 checks passed
@mraible
mraible deleted the media-file-own-weblog-6.1.x branch November 18, 2026 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants