Skip to content

Limit the size and download time of feeds fetched by the planet aggregator - #326

Merged
mraible merged 1 commit into
roller-6.1.xfrom
planet-fetch-limits-6.1.x
Nov 18, 2026
Merged

mraible merged 1 commit into
roller-6.1.xfrom
planet-fetch-limits-6.1.x

Conversation

@mraible

@mraible mraible commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

The 6.1.x version of #314. RomeFeedFetcher was the same as master's, so the change applies as is, with Java 11 syntax (no pattern-matching instanceof, no text blocks in the test).

RomeFeedFetcherLimitsTest (6 cases) covers oversized, slow and stalled feeds and non-HTTP URLs. mvn test passes (538 run, 1 skipped).

CHANGES entries for the 6.1.8 fixes will come in one PR.

…gator

The planet feed fetcher now stops reading a feed once it passes planet.aggregator.fetch.maxBytes (5 MB by default) and gives up on a feed that hasn't fully arrived within planet.aggregator.fetch.maxSeconds (30 seconds by default). Before, only the connection and response headers had timeouts, so a large or slowly sent feed could hold up the feed updater. A Content-Length over the limit is rejected before the body is read.

Feed URLs other than http and https now fail with a FetcherException that says so, instead of an IllegalArgumentException from the HTTP client.

@snoopdave snoopdave left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review of 312be749b: The size and download-time limits cover the remote feed fetch path. The twin PR has no missing fix hunks; its differences are consistent with Java 11 syntax and test formatting. Static review found no actionable defects.

No issues found.

@mraible
mraible requested a review from snoopdave November 18, 2026 03:21

@snoopdave snoopdave left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@mraible
mraible merged commit 0b497e1 into roller-6.1.x Nov 18, 2026
7 checks passed
@mraible
mraible deleted the planet-fetch-limits-6.1.x branch November 18, 2026 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants