Repository navigation
Limit the size and download time of feeds fetched by the planet aggregator - #326
Merged
Merged
Conversation
…gator The planet feed fetcher now stops reading a feed once it passes planet.aggregator.fetch.maxBytes (5 MB by default) and gives up on a feed that hasn't fully arrived within planet.aggregator.fetch.maxSeconds (30 seconds by default). Before, only the connection and response headers had timeouts, so a large or slowly sent feed could hold up the feed updater. A Content-Length over the limit is rejected before the body is read. Feed URLs other than http and https now fail with a FetcherException that says so, instead of an IllegalArgumentException from the HTTP client.
snoopdave
reviewed
Nov 18, 2026
snoopdave
left a comment
Contributor
There was a problem hiding this comment.
Review of 312be749b: The size and download-time limits cover the remote feed fetch path. The twin PR has no missing fix hunks; its differences are consistent with Java 11 syntax and test formatting. Static review found no actionable defects.
No issues found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 6.1.x version of #314. RomeFeedFetcher was the same as master's, so the change applies as is, with Java 11 syntax (no pattern-matching instanceof, no text blocks in the test).
RomeFeedFetcherLimitsTest (6 cases) covers oversized, slow and stalled feeds and non-HTTP URLs. mvn test passes (538 run, 1 skipped).
CHANGES entries for the 6.1.8 fixes will come in one PR.