Repository navigation
Limit the size and download time of feeds fetched by the planet aggregator - #314
Merged
Merged
Conversation
…gator The planet feed fetcher now stops reading a feed once it passes planet.aggregator.fetch.maxBytes (5 MB by default) and gives up on a feed that hasn't fully arrived within planet.aggregator.fetch.maxSeconds (30 seconds by default). Before, only the connection and response headers had timeouts, so a large or slowly sent feed could hold up the feed updater. A Content-Length over the limit is rejected before the body is read. Feed URLs other than http and https now fail with a FetcherException that says so, instead of an IllegalArgumentException from the HTTP client.
snoopdave
reviewed
Nov 18, 2026
snoopdave
left a comment
Contributor
There was a problem hiding this comment.
Review of fff56e2a4: The size and download limits are applied in the feed fetch path, and the new tests cover normal, oversized, slow, stalled, and non-HTTP responses. PR #326 has no substantive fix hunk missing here; its syntax differences match the Java 11 branch. I found no verified issue requiring a change.
No issues found.
This was referenced Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The planet feed fetcher now has one deadline for the whole fetch and a size limit for the body. Before, only the connection and response headers had timeouts.
planet.aggregator.fetch.maxBytes(default 5 MB) caps the body; aContent-Lengthover it is rejected before reading.planet.aggregator.fetch.maxSeconds(default 30) covers connecting, the headers and the body, so a feed that stalls or arrives slowly is cancelled.FetcherExceptionthat says so. Localweblogger:feeds are handled before this, as before.The new properties are in
roller.properties, next to the otherplanet.aggregator.*settings.Tests:
RomeFeedFetcherLimitsTestruns an in-JVM HTTP server and covers a normal feed, oversized feeds (with and withoutContent-Length), a slow and a stalled feed, and a non-HTTP URL.RomeFeedFetcherLocalTestandWebloggerRomeFeedFetcherTeststill pass, andmvn testpasses (755 tests).CHANGES entries for this and the related fixes will come in one PR.