Repository navigation
Remove media pages nothing links to - #309
Merged
Merged
Conversation
The mediaFileImageDim action and the overlay mediaFileAdd action, with their tiles and JSPs (MediaFileImageDimension.jsp, MediaFileAddSuccessInclude.jsp), aren't linked from any page; the entry editor inserts media through mediaFileImageChooser. Their JSPs built media links that Roller can't serve.
snoopdave
reviewed
Nov 18, 2026
snoopdave
left a comment
Contributor
There was a problem hiding this comment.
Review of 78eccc231: The removed views and action have no remaining references, and the active media flows use the retained routes and permalinks. No actionable issues found in this read-only review; builds and tests were not run.
No issues found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes two Struts actions that no page links to, with their tiles and JSPs:
mediaFileImageDim(MediaFileImageDim,.MediaFileImageDimension,MediaFileImageDimension.jsp)mediaFileAddin/roller-ui/authoring/overlay, with its.MediaFileAddIncludeand.MediaFileAddSuccessIncludetiles andMediaFileAddSuccessInclude.jsp. The regularmediaFileAddandMediaFileAdd.jspstay.The entry editor and the category page insert media through the overlay
mediaFileImageChooser, which uses each file's permalink (MediaFileCard.jsp), and the upload result page does the same. The two removed JSPs built/roller-ui/rendering/media-resources/<id>links, which Roller answers with 404 because the request parser takes the first path element as the weblog handle; the overlay add page also never set the new file's ID on its bean.AuthoringActionScopingTestdrops itsMediaFileImageDimcase and keeps theEntryAddWithMediaFileone.mvn testpasses (749 tests), and the Playwright database-login suite passes againstjetty:run(20 run, 3 OIDC tests skipped), including the media library tests.