Skip to content

Remove media pages nothing links to - #309

Merged
mraible merged 1 commit into
masterfrom
remove-unused-media-pages
Nov 18, 2026
Merged

mraible merged 1 commit into
masterfrom
remove-unused-media-pages

Conversation

@mraible

@mraible mraible commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

Removes two Struts actions that no page links to, with their tiles and JSPs:

  • mediaFileImageDim (MediaFileImageDim, .MediaFileImageDimension, MediaFileImageDimension.jsp)
  • the overlay mediaFileAdd in /roller-ui/authoring/overlay, with its .MediaFileAddInclude and .MediaFileAddSuccessInclude tiles and MediaFileAddSuccessInclude.jsp. The regular mediaFileAdd and MediaFileAdd.jsp stay.

The entry editor and the category page insert media through the overlay mediaFileImageChooser, which uses each file's permalink (MediaFileCard.jsp), and the upload result page does the same. The two removed JSPs built /roller-ui/rendering/media-resources/<id> links, which Roller answers with 404 because the request parser takes the first path element as the weblog handle; the overlay add page also never set the new file's ID on its bean.

  • AuthoringActionScopingTest drops its MediaFileImageDim case and keeps the EntryAddWithMediaFile one.
  • mvn test passes (749 tests), and the Playwright database-login suite passes against jetty:run (20 run, 3 OIDC tests skipped), including the media library tests.

The mediaFileImageDim action and the overlay mediaFileAdd action, with their tiles and JSPs (MediaFileImageDimension.jsp, MediaFileAddSuccessInclude.jsp), aren't linked from any page; the entry editor inserts media through mediaFileImageChooser. Their JSPs built media links that Roller can't serve.

@snoopdave snoopdave left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review of 78eccc231: The removed views and action have no remaining references, and the active media flows use the retained routes and permalinks. No actionable issues found in this read-only review; builds and tests were not run.

No issues found.

@mraible
mraible requested a review from snoopdave November 18, 2026 03:21

@snoopdave snoopdave left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@mraible
mraible merged commit 9908e1d into master Nov 18, 2026
9 checks passed
@mraible
mraible deleted the remove-unused-media-pages branch November 18, 2026 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants