Repository navigation
Release the persistence session for every request - #307
Merged
Merged
Conversation
PersistenceSessionFilter now comes first in web.xml, so it releases the persistence session for every request, including the ones Spring Security answers itself, such as logins.
snoopdave
reviewed
Nov 18, 2026
snoopdave
left a comment
Contributor
There was a problem hiding this comment.
Review of 8d09fb58a: The filter now wraps login requests handled by Spring Security, and its position ahead of the encoding filter does not introduce request parsing. The new order test would fail on the base branch. Review was read-only; no build was run.
No issues found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 6.1.x version of the
web.xmlpart of #302.PersistenceSessionFilternow comes first inweb.xml, so it releases the persistence session for every request, including the ones Spring Security answers itself, such as login posts. The filter doesn't read the request, so it can come ahead ofCharEncodingFilter. #302's other change, re-checking the stored password before re-encoding it, isn't needed here: 6.1.x doesn't re-encode passwords at login.FilterOrderTestchecks thatPersistenceSessionFilteris the first filter mapping.mvn testpasses on JDK 21 (533 tests, 1 skipped, the same as the branch), and the Selenium integration tests pass, including the initial setup and login.