Skip to content

Release the persistence session for every request - #307

Merged
mraible merged 1 commit into
roller-6.1.xfrom
persistence-session-filter-first-6.1.x
Nov 18, 2026
Merged

mraible merged 1 commit into
roller-6.1.xfrom
persistence-session-filter-first-6.1.x

Conversation

@mraible

@mraible mraible commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

The 6.1.x version of the web.xml part of #302.

PersistenceSessionFilter now comes first in web.xml, so it releases the persistence session for every request, including the ones Spring Security answers itself, such as login posts. The filter doesn't read the request, so it can come ahead of CharEncodingFilter. #302's other change, re-checking the stored password before re-encoding it, isn't needed here: 6.1.x doesn't re-encode passwords at login.

  • FilterOrderTest checks that PersistenceSessionFilter is the first filter mapping.
  • mvn test passes on JDK 21 (533 tests, 1 skipped, the same as the branch), and the Selenium integration tests pass, including the initial setup and login.

PersistenceSessionFilter now comes first in web.xml, so it releases the persistence session for every request, including the ones Spring Security answers itself, such as logins.

@snoopdave snoopdave left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review of 8d09fb58a: The filter now wraps login requests handled by Spring Security, and its position ahead of the encoding filter does not introduce request parsing. The new order test would fail on the base branch. Review was read-only; no build was run.

No issues found.

@mraible
mraible requested a review from snoopdave November 18, 2026 03:21

@snoopdave snoopdave left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@mraible
mraible merged commit 875ef06 into roller-6.1.x Nov 18, 2026
7 checks passed
@mraible
mraible deleted the persistence-session-filter-first-6.1.x branch November 18, 2026 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants