Repository navigation
Name the app that reports each required check - #305
Merged
Merged
Conversation
ASF Infra refused the ruleset update with "Invalid rule 'required_status_checks': Invalid parameter required_status_checks: Invalid integration ids". Each required check now names the GitHub Actions app (app_slug: github-actions), which reports all of them, CodeQL included.
The default branch ruleset also covered release/* and rel/*, but no workflow runs on pull requests to those branches, so a pull request there could never get the required checks. They now have their own ruleset that keeps the deletion and force-push protection and the review rule, without required status checks.
Contributor
Author
|
@snoopdave, could you take another look at this one? I moved release/* and rel/* into their own ruleset as you suggested. Until it merges, each push to master re-runs .asf.yaml and fails with "Invalid integration ids", so master still doesn't require a review or CI, and the roller-6.1.x ruleset hasn't been created. |
snoopdave
reviewed
Nov 20, 2026
snoopdave
left a comment
Contributor
There was a problem hiding this comment.
Review of e8cc9c67b: The required check names match the workflows for master and roller-6.1.x. Release branches now have a separate ruleset without checks that do not run there. No actionable issues found.
Earlier comments: 1 of 1 resolved.
No new issues found.
Contributor
Author
snoopdave
approved these changes
Nov 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A fix for #303. ASF Infra couldn't apply its rulesets and reported this to commits@ and dev@:
Since the update failed as a whole, none of #303's rules apply yet. The master ruleset still has only its deletion and force-push rules, the
roller-6.1.xruleset wasn't created, and the merge button doesn't wait for a review or for CI. The pull request settings did apply, so auto-merge is on; until this is merged, an auto-merge would go through right away.Each required check now names the app that reports it,
app_slug: "github-actions", which the.asf.yamldocs say is resolved to its integration ID. Every required check on both branches comes from GitHub Actions (app 15368), CodeQL included; I checked the check runs on the latest commits of master and roller-6.1.x. The check names are unchanged. Each ruleset now also requires every review conversation to be resolved before a merge.The default branch ruleset also covered
release/*andrel/*, but no workflow runs on pull requests to those branches, so a pull request there could never get the required checks. They now have their own "Release Branch Protection" ruleset, with the same deletion and force-push protection and review rule and no required status checks.After it merges, I'll check that the rulesets show the review and status-check rules.