Skip to content

Name the app that reports each required check - #305

Merged
mraible merged 3 commits into
masterfrom
fix-required-check-app
Nov 20, 2026
Merged

mraible merged 3 commits into
masterfrom
fix-required-check-app

Conversation

@mraible

@mraible mraible commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

A fix for #303. ASF Infra couldn't apply its rulesets and reported this to commits@ and dev@:

Validation failed while updating ruleset 'Default Branch Protection' (20818706): ["Invalid rule 'required_status_checks': Invalid parameter required_status_checks: Invalid integration ids"]

Since the update failed as a whole, none of #303's rules apply yet. The master ruleset still has only its deletion and force-push rules, the roller-6.1.x ruleset wasn't created, and the merge button doesn't wait for a review or for CI. The pull request settings did apply, so auto-merge is on; until this is merged, an auto-merge would go through right away.

Each required check now names the app that reports it, app_slug: "github-actions", which the .asf.yaml docs say is resolved to its integration ID. Every required check on both branches comes from GitHub Actions (app 15368), CodeQL included; I checked the check runs on the latest commits of master and roller-6.1.x. The check names are unchanged. Each ruleset now also requires every review conversation to be resolved before a merge.

The default branch ruleset also covered release/* and rel/*, but no workflow runs on pull requests to those branches, so a pull request there could never get the required checks. They now have their own "Release Branch Protection" ruleset, with the same deletion and force-push protection and review rule and no required status checks.

After it merges, I'll check that the rulesets show the review and status-check rules.

ASF Infra refused the ruleset update with "Invalid rule 'required_status_checks': Invalid parameter required_status_checks: Invalid integration ids". Each required check now names the GitHub Actions app (app_slug: github-actions), which reports all of them, CodeQL included.
@mraible
mraible requested a review from snoopdave November 17, 2026 17:05

@snoopdave snoopdave left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review of 7cc89aa52: The check names match the master and roller-6.1.x workflows, and the listed jobs run through GitHub Actions. The ruleset also covers release branches where those workflows do not run.

Comment thread .asf.yaml Resolved
The default branch ruleset also covered release/* and rel/*, but no workflow runs on pull requests to those branches, so a pull request there could never get the required checks. They now have their own ruleset that keeps the deletion and force-push protection and the review rule, without required status checks.
@mraible
mraible requested a review from snoopdave November 18, 2026 04:15
@mraible

mraible commented Nov 19, 2026

Copy link
Copy Markdown
Contributor Author

@snoopdave, could you take another look at this one? I moved release/* and rel/* into their own ruleset as you suggested. Until it merges, each push to master re-runs .asf.yaml and fails with "Invalid integration ids", so master still doesn't require a review or CI, and the roller-6.1.x ruleset hasn't been created.

@snoopdave snoopdave left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review of e8cc9c67b: The required check names match the workflows for master and roller-6.1.x. Release branches now have a separate ruleset without checks that do not run there. No actionable issues found.

Earlier comments: 1 of 1 resolved.

No new issues found.

@mraible

mraible commented Nov 20, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for going through all of them, Dave! Your reviews found no issues on these, but they're marked "Commented", so GitHub doesn't count them as approvals. Could you approve them? This one first, please, so the branch protection rules can take effect.

#356 can wait, since it builds on #353, which has a comment from you to fix first. I'm working through your other comments now and will push the fixes in one batch.

@mraible
mraible merged commit 53868dd into master Nov 20, 2026
9 checks passed
@mraible
mraible deleted the fix-required-check-app branch November 20, 2026 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants