RATIS-2311. Check appliedIndex gap before starting a transfer election - #1586
Merged
szetszwo merged 6 commits intoOct 1, 2026
Merged
Conversation
Elia-Renzoni
force-pushed
the
refactor/transfer-leadership
branch
from
September 15, 2026 15:35
7c5ef5f to
23e8344
Compare
Contributor
Author
|
@szetszwo Could you take a look at this PR? Thanks! |
Contributor
|
Sure, will review this. |
Elia-Renzoni
force-pushed
the
refactor/transfer-leadership
branch
from
September 24, 2026 07:42
23e8344 to
db777b1
Compare
Contributor
|
I looked at this once. Since this PR adds new public API and conf, I need some more time to think about the changes. |
szetszwo
reviewed
Sep 29, 2026
szetszwo
left a comment
szetszwo
left a comment
Contributor
There was a problem hiding this comment.
@Elia-Renzoni , thanks for working on this! It looks quite good.
- Please use 2-space for indentation.
- See also the comments inlined.
Signed-off-by: Elia Renzoni <[email protected]>
Signed-off-by: Elia Renzoni <[email protected]>
Signed-off-by: Elia Renzoni <[email protected]>
Signed-off-by: Elia Renzoni <[email protected]>
Signed-off-by: Elia Renzoni <[email protected]>
Elia-Renzoni
force-pushed
the
refactor/transfer-leadership
branch
from
October 1, 2026 13:41
7a9f350 to
110c11a
Compare
Signed-off-by: Elia Renzoni <[email protected]>
Contributor
@Elia-Renzoni , please don't force push after a review has started. Otherwise, it also forces the reviewers to read everything again since it is hard to see only the new changes. |
szetszwo
approved these changes
Oct 1, 2026
szetszwo
left a comment
szetszwo
left a comment
Contributor
There was a problem hiding this comment.
+1 the change looks good!
szetszwo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR makes the leadership transfer check in TransferLeadership#isFollowerUpToDate stricter by also verifying that the gap between the target follower's matchIndex (replicated log) and its appliedIndex (state machine apply progress) is within an acceptable threshold, in addition to the existing matchIndex up-to-date check
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/RATIS-2311?page=com.atlassian.jira.plugin.system.issuetabpanels%3Aall-tabpanel
How was this patch tested?
Added
testRiskyLeadershipTransferto the abstractLeaderElectionTestsclass, alongside the existingtestTransferLeaderandtestTransferLeaderTimeouttests