RATIS-2227. LogEntryProto leak in SegmentedRaftLog#1199
Merged
szetszwo merged 1 commit intoapache:masterfrom Dec 25, 2024
Merged
RATIS-2227. LogEntryProto leak in SegmentedRaftLog#1199szetszwo merged 1 commit intoapache:masterfrom
szetszwo merged 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
10x10 Testing: TestRaftWithGrpc looks to be working fine so far. |
szetszwo
approved these changes
Dec 25, 2024
Contributor
szetszwo
left a comment
szetszwo
left a comment
There was a problem hiding this comment.
+1 the change looks good.
Contributor
Yes, it looks great! |
slfan1989
pushed a commit
to slfan1989/ratis
that referenced
this pull request
May 6, 2026
(cherry picked from commit accb612)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When GrpcLogAppender sends logEntry to Follower, if an exception is encountered, some leaks will occur.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/RATIS-2227
How was this patch tested?
ci: https://github.com/jianghuazhu/ratis/actions/runs/12492897006