RATIS-2045. SnapshotInstallationHandler doesn't notify follower when snapshotIndex is -1 and firstAvailableLogIndex is 0#1053
Merged
szetszwo merged 4 commits intoapache:masterfrom Mar 20, 2024
Conversation
Contributor
|
@duongkame , there are some test failures related to |
Contributor
I created a custom build with advance detection here: https://github.com/duongkame/ratis/actions/runs/8351812136 Looks like this is because the retained log entries in SimpleStateMachine4Testing cache are not released. Probably because the state machine is not closed. Filed RATIS-2046. |
szetszwo
reviewed
Mar 20, 2024
…otInstallationHandler.java
szetszwo
reviewed
Mar 20, 2024
…otInstallationHandler.java
szetszwo
reviewed
Mar 20, 2024
Comment on lines
+356
to
+357
| } No newline at end of file | ||
| } |
Contributor
There was a problem hiding this comment.
@hemantk-12 , could you revert this whitespace change? I tried to do in on the GitHub web ui but it did not work.
symious
pushed a commit
to symious/ratis
that referenced
this pull request
Apr 11, 2024
…snapshotIndex is -1 and firstAvailableLogIndex is 0 (apache#1053)
szetszwo
added a commit
to szetszwo/ratis
that referenced
this pull request
Apr 11, 2024
…er when snapshotIndex is -1 and firstAvailableLogIndex is 0 (apache#1053)" This reverts commit 72c060d.
szetszwo
added a commit
to szetszwo/ratis
that referenced
this pull request
Apr 15, 2024
…er when snapshotIndex is -1 and firstAvailableLogIndex is 0 (apache#1053)" This reverts commit 72c060d.
duongkame
added a commit
to duongkame/ratis
that referenced
this pull request
Apr 17, 2024
…er when snapshotIndex is -1 and firstAvailableLogIndex is 0 (apache#1053)" This reverts commit 72c060d.
szetszwo
added a commit
to szetszwo/ratis
that referenced
this pull request
Apr 17, 2024
…er when snapshotIndex is -1 and firstAvailableLogIndex is 0 (apache#1053)" This reverts commit 72c060d.
whbing
pushed a commit
to whbing/ratis
that referenced
this pull request
Apr 20, 2024
…er when snapshotIndex is -1 and firstAvailableLogIndex is 0 (apache#1053)" This reverts commit 72c060d.
SzyWilliam
pushed a commit
to SzyWilliam/ratis
that referenced
this pull request
Jun 12, 2024
…snapshotIndex is -1 and firstAvailableLogIndex is 0 (apache#1053)
szetszwo
pushed a commit
to szetszwo/ratis
that referenced
this pull request
Jun 16, 2024
…snapshotIndex is -1 and firstAvailableLogIndex is 0 (apache#1053)
This was referenced May 10, 2025
slfan1989
pushed a commit
to slfan1989/ratis
that referenced
this pull request
May 6, 2026
…snapshotIndex is -1 and firstAvailableLogIndex is 0 (apache#1053)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When the leader has firstAvailableLogIndex
0and the follower node is bootstrapping and doesn't have any snapshot, the leader doesn't notify the follower to install the snapshot because the current condition is alwaystrueifsnapshotIndexis-1(default value) andfirstAvailableLogIndexis0(when the leader has logs form 0th index).As part of this change, we are changing the condition to notify when
snapshotIndexis-1. IfsnapshotIndexis not-1, then continue withsnapshotIndex + 1 >= firstAvailableLogIndex && firstAvailableLogIndex > INVALID_LOG_INDEX.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/RATIS-2045
How was this patch tested?
Existing unit tests for now.