MINOR: Include local file paths in reader diagnostics - #3804
Merged
Merged
Conversation
Signed-off-by: 1fanwang <[email protected]>
divjotarora
approved these changes
Sep 21, 2026
wgtmac
approved these changes
Sep 23, 2026
Member
|
Thanks @1fanwang for fixing this and @divjotarora for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
When a local Parquet file is invalid, the error shows a Java object ID instead of the filename. Callers cannot identify the failing input.
Related to #3354. This fixes the built-in local input implementation, not the third-party input in that report.
What changes are included in this PR?
Return the stored path from the local input's string representation, as Hadoop-backed inputs already do.
Are these changes tested?
Testing Done
On Java 17, the same program opens a real ten-byte file through the Parquet reader.
Before, at 2df8d02:
After:
Run from either checkout:
mvn -q -pl parquet-hadoop -am -DskipTests package dependency:build-classpath -Dmdep.outputFile=target/runtime-classpath java -cp "parquet-common/target/classes:parquet-hadoop/target/classes:$(cat parquet-hadoop/target/runtime-classpath)" target/InvalidLocalFileProbe.java invalid.parquetReproducer source
Save this as target/InvalidLocalFileProbe.java after the build:
Are there any user-facing changes?
Local-file errors and reader file identifiers now show the supplied path. File contents and read behavior are unchanged.