Skip to content

Remove main branch protect#8

Merged
SteNicholas merged 1 commit into
apache:mainfrom
JingsongLi:protect
Jul 8, 2024
Merged

Remove main branch protect#8
SteNicholas merged 1 commit into
apache:mainfrom
JingsongLi:protect

Conversation

@JingsongLi

Copy link
Copy Markdown
Contributor

Every commit will send a email to private:
Protected Branches for paimon-rust.git has been updated

Maybe we don't need to use protect branch?

Comment thread .asf.yaml
squash: true
merge: false
rebase: false
rebase: true

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use rebase to some PRs collaborations with multiple people.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this.

@Xuanwo

Xuanwo commented Jul 8, 2024

Copy link
Copy Markdown
Member

Every commit will send a email to private:
Protected Branches for paimon-rust.git has been updated

I've never heard of this. It might be because the project is relatively new and the same PR base doesn't have an asf.yml file yet. I believe this issue will resolve itself in the future.

@Xuanwo

Xuanwo commented Jul 8, 2024

Copy link
Copy Markdown
Member

I've never heard of this. It might be because the project is relatively new and the same PR base doesn't have an asf.yml file yet. I believe this issue will resolve itself in the future.

Confirmed with @JingsongLi. I don't know what happened. Let's disable it for now.

@SteNicholas SteNicholas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants