feat(io): Align FileStatus with the Java API.#45
Conversation
| .map(|meta| FileStatus { | ||
| size: meta.metadata().content_length(), | ||
| is_dir: meta.metadata().is_dir(), | ||
| last_modification_time: meta |
There was a problem hiding this comment.
When testing, I found that the directory's last_modification_time = 0 for a dir. But for the LocalFileIO in java it's not.
Is this a bug for opendal Fs service ? CC @Xuanwo
There was a problem hiding this comment.
I believe it's related to apache/opendal#4615. Would you like to take a look? It might be complex to resolve entirely, but we can start by fixing it for the fs backend first.
There was a problem hiding this comment.
thanks, will take a look
| pub size: u64, | ||
| pub is_dir: bool, | ||
| pub path: String, | ||
| pub last_modification_time: i64, |
There was a problem hiding this comment.
I'm thinking about using chrono::DateTime to make it easier to use. What do you think?
|
CC @Xuanwo |
| Ok(FileStatus { | ||
| size: meta.content_length(), | ||
| is_dir: meta.is_dir(), | ||
| last_modification_time: meta.last_modified(), |
There was a problem hiding this comment.
How about using last_modified or modified for short?
| /// TODO: Support building Operator from HashMap via options. | ||
| pub fn new(_: HashMap<String, String>) -> Result<Self> { | ||
| let op = Operator::from_config(MemoryConfig::default()) | ||
| let op = Operator::new(Fs::default().root("/")) |
There was a problem hiding this comment.
It's better not to hard-code fs here, but I think it's a good starting point.
There was a problem hiding this comment.
yes, I think here should construct the fileIO according to the scheme. I'd like to do it in another pr.
3 participants
close #44