refactor: Refactor error in DataType#36
Merged
Merged
Conversation
Xuanwo
reviewed
Aug 3, 2024
| } | ||
|
|
||
| #[derive(Debug, Snafu)] | ||
| pub enum DataTypeError { |
Member
There was a problem hiding this comment.
Hi, we usually expose only one error in each crate to keep them user-friendly. I will suggest to add DataTypeInvalid as a new enum in Error directly. In this way, we can use paimon::Error everywhere.
Aitozi
reviewed
Aug 4, 2024
| pub fn with_nullable(nullable: bool, length: usize) -> Result<Self, Error> { | ||
| if !(Self::MIN_LENGTH..=Self::MAX_LENGTH).contains(&length) { | ||
| return Err("Character string length must be between 1 and 255 (both inclusive)."); | ||
| return DataTypeInvalidSnafu { |
Contributor
There was a problem hiding this comment.
Can we simplify this by ensure!(length < Self::MIN_LENGTH, DataTypeInvalidSnafu {message: "Binary string length must be at least 1."}); ?
The same as below
Contributor
Author
There was a problem hiding this comment.
Can we simplify this by
ensure!(length < Self::MIN_LENGTH, DataTypeInvalidSnafu {message: "Binary string length must be at least 1."});?The same as below
This simplifies things a bit, but the readability of the code is reduced.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
link: #32