Skip to content

feat: Add file io#23

Merged
SteNicholas merged 2 commits into
apache:mainfrom
Xuanwo:add-file-io
Jul 30, 2024
Merged

feat: Add file io#23
SteNicholas merged 2 commits into
apache:mainfrom
Xuanwo:add-file-io

Conversation

@Xuanwo

@Xuanwo Xuanwo commented Jul 29, 2024

Copy link
Copy Markdown
Member

This PR will add basic file io support.

Signed-off-by: Xuanwo <[email protected]>

@XuQianJin-Stars XuQianJin-Stars left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread crates/paimon/src/io/file_io.rs Outdated
Comment thread crates/paimon/src/error.rs Outdated
Signed-off-by: Xuanwo <[email protected]>
@Xuanwo

Xuanwo commented Jul 30, 2024

Copy link
Copy Markdown
Member Author

Hi, @SteNicholas, all comments have been addressed. PTAL.

@SteNicholas SteNicholas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@SteNicholas SteNicholas merged commit 5ef683a into apache:main Jul 30, 2024
@Xuanwo Xuanwo deleted the add-file-io branch July 30, 2024 09:19
@Xuanwo Xuanwo restored the add-file-io branch July 30, 2024 09:19
@Xuanwo Xuanwo deleted the add-file-io branch July 30, 2024 09:19
devillove084 pushed a commit to devillove084/paimon-rust that referenced this pull request Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants