feat(spec): Add Manifest List#17
Merged
Merged
Conversation
QuakeWang
reviewed
Jul 10, 2024
Xuanwo
reviewed
Jul 17, 2024
Xuanwo
left a comment
Xuanwo
left a comment
Member
There was a problem hiding this comment.
Thanks for your PR. It looks good to me overall.
Member
|
cc @JingsongLi and @SteNicholas for another look. |
Contributor
|
Hi @Asura7969 , can you rebase and resolve conflicts. |
# Conflicts: # crates/paimon/src/spec/mod.rs
Contributor
Author
done |
SteNicholas
approved these changes
Jul 30, 2024
Member
|
@Asura7969, rebase main branch and resolve the conflicts. Meanwhile, you could refer to f8c156f for updating the code link of reference. |
# Conflicts: # crates/paimon/src/spec/mod.rs
Contributor
Author
|
@SteNicholas done |
Member
|
Hi, @SteNicholas, I believe this PR is happy to go. |
SteNicholas
approved these changes
Aug 2, 2024
devillove084
pushed a commit
to devillove084/paimon-rust
that referenced
this pull request
Aug 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #14
This PR will add Manifest List.