You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The reason will be displayed to describe this comment to others. Learn more.
One noteworthy aspect is the equivalence comparison of Decimal. In Java, Decimal uses compareTo to achieve equivalence, which can maintain equality even at different scales.
One noteworthy aspect is the equivalence comparison of Decimal. In Java, Decimal uses compareTo to achieve equivalence, which can maintain equality even at different scales.
Good catch! I have fixed this.
Datum now has a manual PartialEq impl instead of derive(PartialEq). The Decimal variant normalizes both sides to a common scale before comparing unscaled values, matching Java Decimal.equals() which delegates to compareTo() == 0
For example, Decimal(unscaled=10, scale=1) and Decimal(unscaled=100, scale=2) are now considered equal since both represent 1.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #154
Add foundational predicate types and field-mapping utilities for filter pushdown. This is infrastructure-only — no behavior change in the read path.
Brief change log
Tests
API and Format
New public API added:
Documentation