enhance the slave node promotion#340
Merged
Merged
Conversation
greatsharp
commented
Aug 16, 2025
greatsharp
commented
Contributor
- When slave node doing full sync replication, it will return 'LOADING kvrocks is restoring the db from backup' error by executing 'cluster info' command, but it will return empty keyspace info if executing 'info' command.
- We should skip the node if executing 'cluster info' command error.
- If slave node doing full sync replication failed, and slave node reboot, both 'cluster info' and info command can execute correctly, but the sequence returned is 0.
- We should skip the node if sequence is 0 or role is not slave.
Contributor
Author
|
this enhancement can prevent controller select an empty slave(sequence=0) into new master, but it will cause failover API failed in case of empty shard. |
git-hulk
approved these changes
Sep 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.