Skip to content

Fix Github commits data lost#1062

Merged
mindlesscloud merged 2 commits into
mainfrom
fix1061
Jan 13, 2022
Merged

Fix Github commits data lost#1062
mindlesscloud merged 2 commits into
mainfrom
fix1061

Conversation

@klesh

@klesh klesh commented Jan 13, 2022

Copy link
Copy Markdown
Contributor

Summary

Fix issues #1061

Key Points

  • This is a breaking change
  • New or existing documentation is updated

@klesh klesh requested a review from kevin-kline January 13, 2022 04:39
@mindlesscloud mindlesscloud merged commit 0c0efd8 into main Jan 13, 2022
@mindlesscloud mindlesscloud deleted the fix1061 branch January 13, 2022 15:41
@joncodo

joncodo commented Jan 13, 2022

Copy link
Copy Markdown
Contributor

I know that this is a good thing to merge but I want to make sure it satisfies the problems that @hezyin brought up to me yesterday about a more general fix since we will need many "if" checks across the system under these circumstances. Having said that, I think it might be the only way.

@joncodo

joncodo commented Jan 13, 2022

Copy link
Copy Markdown
Contributor
  • QA this
  • Check for error messages in the logs to be sure they make sense

@Startrekzky Startrekzky added pr-type/bug-fix This PR fixes a bug component/framework This issue or PR relates to the framework labels Jan 14, 2022
mamh2021 pushed a commit to golang108/merico-dev-lake that referenced this pull request Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/framework This issue or PR relates to the framework pr-type/bug-fix This PR fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants