Skip to content

Support bigquery CAST AS x [STRING|DATE] FORMAT syntax - #978

Merged
alamb merged 1 commit into
apache:mainfrom
getsynq:cast-format
Oct 20, 2023
Merged

Support bigquery CAST AS x [STRING|DATE] FORMAT syntax#978
alamb merged 1 commit into
apache:mainfrom
getsynq:cast-format

Conversation

@lustefaniak

@lustefaniak lustefaniak commented Sep 24, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

@lustefaniak
lustefaniak force-pushed the cast-format branch 2 times, most recently from 0d42a8a to c274bcd Compare September 25, 2023 15:50
alamb
alamb reviewed Oct 5, 2023
View reviewed changes

@alamb alamb left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @lustefaniak -- sorry I missed this one in the sea of reiviews. I think it is looking good in my mind -- I have some suggestions -- let me know what you think

Comment thread src/ast/mod.rs Outdated
Comment thread src/ast/mod.rs Outdated
@alamb

alamb commented Oct 5, 2023

Copy link
Copy Markdown
Contributor

I think the CI failures are not related to the changes in this PR -- if you merge up / rebase from main they should be solved. See #995

@lustefaniak
lustefaniak force-pushed the cast-format branch 2 times, most recently from ebe32db to 00bd9f3 Compare October 20, 2023 09:01
@alamb alamb changed the title bigquery: CAST AS x FORMAT support Support bigquery CAST AS x FORMAT syntax Oct 20, 2023
@alamb alamb changed the title Support bigquery CAST AS x FORMAT syntax Support bigquery CAST AS x [STRING|DATE] FORMAT syntax Oct 20, 2023
alamb
alamb approved these changes Oct 20, 2023
View reviewed changes

@alamb alamb left a comment

Copy link