Skip to content

feat: add ALTER ROLE syntax of PostgreSQL and MS SQL Server - #942

Merged
alamb merged 6 commits into
apache:mainfrom
r4ntix:support-alter-role
Aug 17, 2023
Merged

alamb merged 6 commits into
apache:mainfrom
r4ntix:support-alter-role

Conversation

@r4ntix

@r4ntix r4ntix commented Aug 9, 2023

Copy link
Copy Markdown
Contributor

Background

Close #941

What changes are included in this PR

  • add ALTER ROLE syntax of PostgreSQL ✅
  • add ALTER ROLE syntax of MS SQL Server ✅
  • add parser tests ✅

Addtional Context

See #941

@r4ntix
r4ntix force-pushed the support-alter-role branch from fe66a98 to a538f30 Compare August 17, 2023 11:54

@alamb alamb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really nice work @r4ntix -- thank you very much for the contribution. I don't really have anything to add here. The code is nicely structured, well commented and well tested. ❤️

Thanks again

@alamb
alamb merged commit a49ea19 into apache:main Aug 17, 2023
@r4ntix
r4ntix deleted the support-alter-role branch August 17, 2023 14:21
serprex pushed a commit to serprex/sqlparser-rs that referenced this pull request Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The ALTER ROLE syntax is not supported

2 participants