Skip to content

Fix qualified wildcard stringifying - #53

Merged
andygrove merged 5 commits into
apache:masterfrom
thomas-jeepe:master
Apr 27, 2019
Merged

andygrove merged 5 commits into
apache:masterfrom
thomas-jeepe:master

Conversation

@thomas-jeepe

@thomas-jeepe thomas-jeepe commented Apr 22, 2019 •

Copy link
Copy Markdown
Contributor

Issue #52

@coveralls

coveralls commented Apr 22, 2019 •

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 157

  • 29 of 30 (96.67%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+7.3%) to 91.973%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tests/sqlparser_generic.rs 14 15 93.33%
Totals Coverage Status
Change from base Build 148: 7.3%
Covered Lines: 951
Relevant Lines: 1034

💛 - Coveralls

@nickolay

Copy link
Copy Markdown
Contributor

I'd move the roundtrip_qualified_wildcard test from sqlparser_ansi to sqlparser_generic, as the latter has helper functions that let you test the round-tripping easily:

let sql = "SELECT COUNT(Employee.*) FROM northwind.Order JOIN northwind.Employee ON Order.employee = Employee.id";
let _select = verified_only_select(&sql);

(This would also avoid the conflict with the change to SQLStatement::SQLSelect in #51)

See also my question in #52 about validity of this SQL; I think a comment about whether this SQL is valid in some dialects would be helpful.

For the second patch, you might want to run cargo fmt, which we use for auto-formatting the code -- sorry it's not mentioned anywhere!

@nickolay

Copy link
Copy Markdown
Contributor

Excellent, thank you.

@andygrove andygrove left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @thomas-jeepe !

@andygrove
andygrove merged commit 07d66a9 into apache:master Apr 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants