Skip to content

Implement SUBSTRING(col [FROM <expr>] [FOR <expr>]) syntax - #293

Merged
andygrove merged 4 commits into
apache:mainfrom
Dandandan:substring
Feb 7, 2021
Merged

andygrove merged 4 commits into
apache:mainfrom
Dandandan:substring

Conversation

@Dandandan

@Dandandan Dandandan commented Feb 7, 2021 •

Copy link
Copy Markdown
Contributor

This implements syntax for substring(string [from expr] [for expr])

This makes TCP-H Query 22 parse (Enabled it in the tests).

FYI @andygrove

@coveralls

coveralls commented Feb 7, 2021 •

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 545266297

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 25 of 27 (92.59%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.009%) to 90.094%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/ast/mod.rs 9 11 81.82%
Files with Coverage Reduction New Missed Lines %
src/parser.rs 1 86.05%
Totals Coverage Status
Change from base Build 538263797: 0.009%
Covered Lines: 5348
Relevant Lines: 5936

💛 - Coveralls

@Dandandan Dandandan changed the title Implement SUBSTRING(FROM <expr> FOR <expr>) syntax Implement SUBSTRING(col [FROM <expr>] [FOR <expr>]) syntax Feb 7, 2021

@andygrove andygrove left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andygrove
andygrove merged commit 6f0b2dc into apache:main Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants