Repository navigation
feat: support sqlite insert or statement - #281
Merged
Merged
Conversation
Pull Request Test Coverage Report for Build 546765859
💛 - Coveralls |
Dandandan
reviewed
Nov 7, 2020
Dandandan
reviewed
Nov 7, 2020
Contributor
|
Thanks for the contribution! I left a few comments :) |
Contributor
Author
|
I’v changed code following discussion above, please review again.BTW, how long does it take to publish a new version to crates.io? |
Contributor
Author
|
Is there anybody still following this thread? |
Contributor
|
Thanks @zhangli-pear for building this feature. |
Dandandan
reviewed
Dec 14, 2020
Dandandan
approved these changes
Dec 20, 2020
Contributor
|
LGTM now @nickolay do you maybe have any comments? |
Dandandan
reviewed
Dec 23, 2020
Dandandan
reviewed
Dec 23, 2020
Contributor
|
@zhangli-pear can you rebase against the main branch? |
Contributor
Author
|
Done. I didn't notice the conflict before😂. |
Contributor
|
Thanks @zhangli-pear for the changes 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://www.sqlite.org/lang_insert.html