You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I rebased this on top of the current master, but can't share it in this PR, so here's a link to a commit in my fork: nickolay@9e9da81
This is roughly how I "rebased":
$ git reset --hard face972 # this PR's base
$ cargo fmt
$ # Some files were not reformatted in the PR, so undo the changes in them:
$ git checkout -- src/dialect/mod.rs
$ git checkout -- src/sqlast/value.rs
$ git commit -am .....
$ # Produce a patch without formatting changes:
$ git fetch upstream pull/28/head:join-support
$ git diff HEAD..join-support > join-support.patch
$ git checkout master
$ git apply join-support.patch
$ # Fixed conflict in the keywords list
Thanks @fredrikroos I merged this manually and fixed the failing test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supports inner join, left/right/full outer join, cross join and implicit join. Join constraint can be ON expression, USING expression or NATURAL.
There is some formatting noise in this commit that can be dealt with by a cargo-fmt commit in master and then rebasing this PR.