Repository navigation
MySQL: print a space before PARTITION when displaying a table factor - #2423
Merged
Merged
Conversation
`SELECT * FROM employees PARTITION (p0, p2)` rendered back as `SELECT * FROM employeesPARTITION (p0, p2)`, which re-parses as a table function named `employeesPARTITION` with arguments `p0` and `p2` rather than a partition selection on `employees`. The round trip therefore changed the AST, not just the whitespace. `Display for TableFactor::Table` emitted `PARTITION (...)` without a leading space, unlike the sibling clauses in the same arm. Add it. The regression test also pins the `UPDATE`, `DELETE`, alias, join and missing-parenthesis cases, none of which had coverage. Co-Authored-By: Claude Opus 5 <[email protected]>
LucaCappelletti94
approved these changes
Aug 5, 2026
2 of 6 tasks
alamb
approved these changes
Sep 3, 2026
alamb
left a comment
alamb
left a comment
Contributor
There was a problem hiding this comment.
Thank you @LucaCappelletti94 and @shuvamk
# Conflicts: # tests/sqlparser_mysql.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
round-trips to
SELECT * FROM employeesPARTITION (p0, p2), which re-parses as a table function namedemployeesPARTITIONtaking argumentsp0andp2— a different AST, not just different whitespace.Display for TableFactor::TablewritesPARTITION (...)with no leading space, unlike the sibling clauses in the same arm (WITH ORDINALITY,{alias},WITH (...)). The fix adds the space.Test is
parse_table_partition_selectionintests/sqlparser_mysql.rs, coveringSELECT/UPDATE/DELETE, an alias, a join and the missing-parenthesis error path; it fails without the change. Table-levelPARTITIONselection had no test coverage before.