Repository navigation
rework github actions for code coverage - #186
Conversation
This reworks our GitHub Actions workflow to include code coverage via tarpaulin. Note that this is essentially directly lifted from the again[1] crate's methodology. Fixes apache#164. [1] https://github.com/softprops/again/blob/dd5f0013533e28f803b282ebc281e9525ca64d86/.github/workflows/main.yml
|
Here's an example workflow run on my branch. |
|
Looking good! |
nickolay
left a comment
nickolay
left a comment
There was a problem hiding this comment.
Thanks for working on this!
As noted, I can't see the coverage information on coveralls.io -- so can't check how useful it is. Two other things that prevent me from merging this is the duration of the CI run and the question of CI's stability in face of Rust nightlies often lacking some components.
|
Thank you! I hope this lets us ditch travis soon. |
|
Sadly tarpaulin seems to perform worse than our previous coverage solution, e.g. https://coveralls.io/builds/31294002/source?filename=src/parser.rs#L244 vs https://coveralls.io/builds/28060470/source?filename=src/parser.rs#L244 |
| # Note that `nightly` is required for `license_template_path`, as | ||
| # it's an unstable feature. | ||
| rust-version: nightly | ||
| - uses: actions/checkout@v2 | ||
| - run: cargo fmt -- --check --config-path <(echo 'license_template_path = "HEADER"') |
There was a problem hiding this comment.
I just noticed this does not use cargo +nightly fmt, making it print a Warning: can't set license_template_path = "HEADER", unstable features are only available in nightly channel. and presumably not run that check.
There was a problem hiding this comment.
Oh no, definitely an oversight on my part. Should be a trivial fix.
3 participants
This reworks our GitHub Actions workflow to include code coverage via
tarpaulin. Note that this is essentially directly lifted from the
again[1] crate's methodology.
Fixes #164.
[1]
https://github.com/softprops/again/blob/dd5f0013533e28f803b282ebc281e9525ca64d86/.github/workflows/main.yml