Skip to content

Implement DROP COLUMN operation in ALTER TABLE statement - #148

Merged
nickolay merged 5 commits into
apache:masterfrom
ivanceras:alter-add-column
Jun 16, 2020
Merged

Implement DROP COLUMN operation in ALTER TABLE statement#148
nickolay merged 5 commits into
apache:masterfrom
ivanceras:alter-add-column

Conversation

@ivanceras

@ivanceras ivanceras commented Jan 1, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

This will fix issue https://github.com/andygrove/sqlparser-rs/issues/147

This change is Reviewable

@benesch

benesch commented Jan 13, 2020

Copy link
Copy Markdown
Contributor

Thanks, this looks good to me! Could you revise so it passes CI? Looks like a few clippy lints failed.

@nickolay

nickolay commented Jun 16, 2020

Copy link
Copy Markdown
Contributor

ALTER TABLE ADD COLUMN was implemented in #203, so I cherry-picked the bits of this PR related to the DROP COLUMN implementation and updated it to close this off.

@coveralls

coveralls commented Jun 16, 2020

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 137649660

  • 24 of 28 (85.71%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 91.803%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/parser.rs 5 6 83.33%
src/ast/ddl.rs 6 9 66.67%
Files with Coverage Reduction New Missed Lines %
src/ast/ddl.rs 1 83.15%
Totals Coverage Status
Change from base Build 137609215: -0.02%
Covered Lines: 4144
Relevant Lines: 4514
💛 - Coveralls

@nickolay
nickolay merged commit 26361fd into apache:master Jun 16, 2020
@nickolay nickolay changed the title Implement ADD COLUMN operation in ALTER TABLE statement Implement DROP COLUMN operation in ALTER TABLE statement Jun 16, 2020
@nickolay

nickolay commented Jun 16, 2020

Copy link
Copy Markdown
Contributor

Thanks!

@nickolay nickolay mentioned this pull request Jun 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

See More

Successfully merging this pull request may close these issues.

4 participants

@ivanceras @benesch @nickolay @coveralls