Skip to content

Update to ASF header / add when missing - #1437

Merged
alamb merged 1 commit into
apache:mainfrom
alamb:alamb/asf_header
Sep 21, 2024
Merged

alamb merged 1 commit into
apache:mainfrom
alamb:alamb/asf_header

Conversation

@alamb

@alamb alamb commented Sep 19, 2024

Copy link
Copy Markdown
Contributor

Part of #1436

Part of being an Apache project is ensuring all source files have the appropriate license header.

This PR updates to the appropriate header, adding it when there wasn't an existing license header

@alamb alamb changed the title Update to ASF header, add when missing. Also run fmt in derive Update to ASF header / add when missing Sep 19, 2024
Comment thread derive/src/lib.rs
input: proc_macro::TokenStream,
visit_type: &VisitType,
) -> proc_macro::TokenStream {
fn derive_visit(input: proc_macro::TokenStream, visit_type: &VisitType) -> proc_macro::TokenStream {

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the result of me running cargo fmt in this directory

@coveralls

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 10948764051

Details

  • 14 of 17 (82.35%) changed or added relevant lines in 15 files are covered.
  • 235 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.006%) to 89.332%

Changes Missing Coverage Covered Lines Changed/Added Lines %
derive/src/lib.rs 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
src/lib.rs 235 12.47%
Totals Coverage Status
Change from base Build 10944120886: -0.006%
Covered Lines: 29602
Relevant Lines: 33137

💛 - Coveralls

@iffyio iffyio left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alamb
alamb enabled auto-merge (squash) September 20, 2024 15:34
@alamb

alamb commented Sep 20, 2024

Copy link
Copy Markdown
Contributor Author

Thanks @iffyio

@alamb
alamb disabled auto-merge September 21, 2024 10:23
@alamb
alamb merged commit 9934f3d into apache:main Sep 21, 2024
@alamb
alamb deleted the alamb/asf_header branch September 21, 2024 10:23
@alamb alamb mentioned this pull request Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants