Skip to content

Fix broken code coverage #164

Description

@nickolay

As noted in https://github.com/andygrove/sqlparser-rs/pull/159 , cargo coveralls fails in CI with an error due to a change in Cargo.lock format. This is supposed to be fixed in roblabla/cargo-travis#66 , but simply upgrading to that version didn't work for me resulting in linking errors. I did not investigate further.

Activity

  1. Dandandan commented on Jun 3, 2020

    @Dandandan
    Contributor
  2. nickolay commented on Jun 3, 2020

    @nickolay
    ContributorAuthor

    I don't know the difference. Whatever works and produces usable coverage info will do, I suppose. The issue is someone willing to put in the work!

  3. maxcountryman commented on Jun 6, 2020

    @maxcountryman
    Contributor

    I'm curious about GitHub Actions as well: I've recently switched over some repos from Travis to Actions and so far it seems to be a nice change. In particular, the configuration is a little more straightforward and there's a nice ecosystem of Actions that are easy to use.

  4. added a commit that references this issue on Jun 6, 2020
    739a8a9
  5. maxcountryman commented on Jun 6, 2020

    @maxcountryman
    Contributor

    I didn't realize there was already a GitHub Actions workflow! 🙂 I put together a quick refactor in case that's a direction you want to go in.

  6. added a commit that references this issue on Jun 7, 2020
    af54eb0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    help wantedExtra attention is needed

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions