Conversation
github-actions
Bot
added
physical-expr
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #25848 +/- ##
==========================================
- Coverage 82.57% 82.56% -0.01%
==========================================
Files 1142 1142
Lines 440728 440728
Branches 440728 440728
==========================================
- Hits 363919 363909 -10
- Misses 54815 54821 +6
- Partials 21994 21998 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Follow-up to #25583.
Rationale for this change
Address the remaining review feedback from #25583: clarify snapshot documentation and avoid building a separate integration-test binary for partition metrics.
What changes are included in this PR?
core_integration.Snapshotand document theflatiteration cache.What is the testing strategy for this PR?
The existing shared-plan metrics test passes under
core_integration. Workspace extended tests, clippy, and formatting checks pass.Are there any user-facing changes?
No behavior or API changes.