Introduce eslint task with semistandard & prettier #36

Activity

1. brody2consult

   self-assigned this

   on Dec 12, 2018
2. n1ru4l commented on Dec 12, 2018

   

   n1ru4l

   on Dec 12, 2018

   Contributor

   More actions

   Can we also add https://github.com/prettier/prettier + https://github.com/prettier/eslint-config-prettier

   👍React with 👍1Reacted by Ross Bender
3. brody2consult

   changed the title [-]Introduce eslint task, likely based on semistandard[/-] [+]Introduce eslint task with semistandard & prettier[/+] on Dec 12, 2018
4. brody2consult commented on Dec 12, 2018

   

   brody2consult

   on Dec 12, 2018

   Last edited by brody2consult

   Author

   More actions

   I would definitely favor adding prettier, just updated the title to reflect this idea.

   When using eslint we generally like to use eslint-config-semistandard, which is basically standard but with semicolons required. I think a major challenge is to avoid conflicts between semistandard rules and prettier rules.

   I found eslint-config-prettier-standard which will hopefully solve this problem for us.
5. brody2consult commented on Dec 12, 2018

   

   brody2consult

   on Dec 12, 2018

   Author

   More actions

   I found [...]

   I meant eslint-config-prettier-standard, which does use prettier & prettier / eslint-config-prettier as suggested above, just fixed my comment.

   There was some interesting discussion in standard/standard#811 & standard/standard#996.
6. brody2consult commented on Dec 13, 2018

   

   brody2consult

   on Dec 13, 2018

   Author

   More actions

   I just raised WIP PR #39 to introduce eslint & prettier, using prettier-eslint-cli instead of eslint-config-prettier. The issue eslint-config-prettier is that it disables a number of eslint rules from standard in order to maintain compatibility with prettier.

   I was able to use prettier-eslint-cli to resolve a number of eslint issues that had been lurking in the code for ages. I hope to get it ready for review and merge in the near future.
7. erisu

   closed this as completedon Jun 4, 2026
8. erisu commented on Jun 4, 2026

   

   erisu

   on Jun 4, 2026

   Member

   More actions

   Closing as stale. ESLint has been added since this issue was opened and is sufficient for the project’s current needs.

   If there is still interest in adopting Prettier, I would recommend raising on the mailing list for discussion and vote as Cordova generally prefers to keep development tools consistent across repositories.