Repository navigation
Major update proposal #20
Description
- drop support for deprecated Node.js versions 0.8, 0.10, 0.12, and 4 (Drop support for old Node.js versions #17)
- simple-plist@1 update
- use ES2015 Object.assign as proposed in PR Updated to use ECMAScript 2015 Object.assign. #14
- consider committing package-lock.json
- use ES6 classes instead of setting prototype functions
- introduce some form of linting using eslint & prettier (Introduce eslint task with semistandard & prettier #36, see discussion in PR [WIP] eslint & prettier enhancements WIP for evaluation & discussion #39)
- cleanup code style issues, using prettier (ibid)
- optional: it would also be ideal if we could port to a more currently maintained testing framework as well
We would need to increase the major version number to avoid breaking dependents that may need to support the older Node.js versions.
I would like to do the following before starting the major update:
- uuid@3 update
- introduce eslint that can be run as an npm script
cleanup major issues found by eslintother possible cleanup that may be triggered by changes to resolve eslint issuesoptional: it would also be ideal if we could port to a more currently maintained testing framework as well- publish minor 1.1.0 update
Activity
n1ru4l commentedon Dec 7, 2018
Object.assignis available since4.9.1and most projects that are usingcordova-node-xcoderequire the minimum node version6/8 as a dependency.Also node versions prior to
6are afaik no longer maintained (https://github.com/nodejs/Release).I think we should certainly start modernizing this code!
brody2consult commentedon Dec 7, 2018
I hope to do this soon, but carefully to avoid breaking any users that may be using some of the older Node.js versions. We need to increase the major package version number whenever we drop one or more Node.js versions according to
semveretiquette.I do think you are right that not many app developers would be using Node.js pre-6.0 and version
6is approaching EOL.brody2consult commentedon Dec 9, 2018
I would like to get PR #24 and ideally PR #12 finished, to be published in a
1.0.1release before starting the major updates. @n1ru4l I think it would be helpful if you could take a look at PR #12, to help determine whether or not we should merge it before publishing the next release.n1ru4l commentedon Dec 9, 2018
Also since nodeunit seems deprecated (https://www.npmjs.com/package/nodeunit#deprecated-project) and from my perspective the current tests are a mess. E.g. adding my test for (#24) was frustrating since there was no nice way to see the actual differences of expected and actual for long strings.
Therefore I would recommend to update to a more mature testing framework. I personally would prefer jest (https://jestjs.io/).
Furthermore tools like prettier and eslint could improve the overall code quality/consistency. I have set those up for multiple projects and could do so for this one too!
brody2consult commentedon Dec 9, 2018
Agreed; I would rather discuss this in a separate issue.
I think it would make sense but not be absolutely necessary to do this after we drop deprecated Node.js version.
fbartho commentedon Mar 4, 2019
Could we possibly either convert this to TypeScript or start shipping TypeScript Definitions?
This would be super straightforward with the move to ES6 classes #38, as it would be nearly self-documenting!
Esemesek commentedon Jul 31, 2019
We are converting https://github.com/react-native-community/cli to TypeScript and it would be awesome if this package had some kind of TS types: shipped with the package or hosted in DefinitelyTyped repository.
erisu commentedon Jun 4, 2026
Closing as resolved and stale. Most of the items have been completed since the ticket was created, and there appears to be another ticket covering ES6.